-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Message actions (1st iteration) #34133
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34133 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 511 511
Lines 22132 22132
Branches 5394 5394
========================================
Hits 16775 16775
Misses 4709 4709
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
1b61c8f
to
9f350d6
Compare
2654d5b
to
10d90ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10d90ca
to
59cbfc4
Compare
Proposed changes (including videos or screenshots)
It removes message actions' initialization from
Meteor.startup()
callbacks. Additionally, it migrates some actions to idiomatic React components.Issue(s)
ARCH-1382
Steps to test or reproduce
Further comments